Use WARN_UNUSED_RESULT in q_math.cpp and deprecate AngleMod #1852
+38
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a duplicate for AngleNormalize360, and the later is better documented. Let's keep only one.
slipher
reviewed
Oct 8, 2025
necessarily-equal
force-pushed
the
AngleNormalize360
branch
from
7393b1d to
9aa7fe6
Compare
Member
|
LGTM |
Member
|
Make sure to merge the Unvanquished one too though, or it will start breaking the build I think |
Contributor
Author
|
Makes sense, locally it builds fine and only provides a warning, but it may break the CI. Note that the warning fix are both in Unvanquished/Unvanquished#3439 and Unvanquished/Unvanquished#3440 |
Contributor
If it requires changes both in daemon and unvanquished, shouldn't it be targeting for-0.56/sync? |
Contributor
Author
|
If it requires changes both in daemon and unvanquished, shouldn't it be targeting for-0.56/sync?
This doesn't change the API or ABI, so I think it's safe to merge
…On 14 October 2025 03:51:05 CEST, VReaperV ***@***.***> wrote:
VReaperV left a comment (DaemonEngine/Daemon#1852)
> Make sure to merge the Unvanquished one too though, or it will start breaking the build I think
If it requires changes both in daemon and unvanquished, shouldn't it be targeting for-0.56/sync?
--
Reply to this email directly or view it on GitHub:
#1852 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion Unvanquished PR: Unvanquished/Unvanquished#3439 (can be merged independently)